Fixed (Favicon related) errors which returned by Zimcheck

[pavel-karatsiuba]

Fix favicons links
Remove broken links
Fix the "redundant data" error after Zimcheck

Fixes #141

[kelson42]

I don't have tested, but from the principle it looks good. But can you please secure the images behind the link are good. Here this is always the same stuff used. It should not. If you take the logo of the welcome page, you should be able to recreate good one in all resolution needed easily.

[kelson42]

I'm not sure my last comment has been understood clearly, here is my test result:

The Android does not pass, and I believe actually the favicon.ico shoudl not be used for many of the other links.

[kelson42]

I have started the review of this PR, but there is already a first regression: the ZIM logo/favicon is not there anymore, see the question mark:

Actually the zìmcheck does detect it:

$ zimcheck dist/phet_
[INFO] Checking zim file dist/phet_
[INFO] Zimcheck version is 3.1.3
[INFO] Verifying ZIM-archive structure integrity...
error 2 opening file "dist/phet_
kelson@camber:~/code/phet$ zimcheck dist/phet_fr_2022-12.zim 
[INFO] Checking zim file dist/phet_fr_2022-12.zim
[INFO] Zimcheck version is 3.1.3
[INFO] Verifying ZIM-archive structure integrity...
[INFO] Avoiding redundant checksum test (already performed by the integrity check).
[INFO] Searching for metadata entries...
[INFO] Searching for Favicon...
[INFO] Searching for main page...
[INFO] Verifying Articles' content...
[INFO] Searching for redundant articles...
  Verifying Similar Articles for redundancies...
[INFO] Checking for redirect loops...
[ERROR] Favicon:
  Favicon is missing
[INFO] Overall Test Status: Fail
[INFO] Total time taken by zimcheck: 3 seconds.

Please fix and introduce a zimcheck test run on the ZIM created with the test, you can look how this is done already at https://github.com/openzim/mwoffliner/tree/main/test

Favicon checker looks good! But there is a problem with safari-pinned-tab.svg which is full black.

[kelson42]

zimcheck does not run in the CI, it does not work like on MWoffliner (given as example in my comment). I have fixed this, but the CI does not pass, because there is still a problem around the ZIM file with the dist.js file. I'm not sure for what that file exactly was used to, but it is not part anymore of the git repository. Please fix and explain why this is really not necessary anymore (I don't get it).

The rest looks good. Thx for the fixes.

[kelson42]

LGTM