-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for redirection in meta http-equiv
#237
Comments
I do not consider this is mandatory at all for Zimit2 release |
Agreed. It was an issue with the www.ready.gov ZIMs, but it did not affect systems reading the ZIM with the Replay ServiceWorker, because AFAIK the redirect was caught by the Service Worker (I may be wrong about that). For zimit2, it's fine to deal with this empirically. |
@benoit74 Not a regression in comparison to Zimit1? It‘s also a pretty common scenario. |
Nope, not a regression AFAIK, it wasn't working in Zimit1 (hence the issue mentioned by Jaifroid on www.ready.gov) |
It is possible to redirect a page with a
meta http-equiv
:See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#http-equiv
So far, Zimit2 does not rewrite these links which are hence not leading to content inside the ZIM.
These links should be considered for rewrite as well.
The result will of course depend on wether the redirect target is present inside the WARC/ZIM or not.
Which in turns depends on how the WARC has been built (i.e. did the system which built the WARC waited long enough to have the redirect target captured as well?) but this is beyond the scope of this issue / warc2zim. warc2zim must just ensure to consider these URLs for rewrite.
The text was updated successfully, but these errors were encountered: