Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redirection in meta http-equiv #237

Closed
benoit74 opened this issue Apr 18, 2024 · 4 comments · Fixed by #353
Closed

Add support for redirection in meta http-equiv #237

benoit74 opened this issue Apr 18, 2024 · 4 comments · Fixed by #353
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Collaborator

It is possible to redirect a page with a meta http-equiv:

<meta http-equiv="refresh" content="3;url=https://www.mozilla.org" />

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#http-equiv

So far, Zimit2 does not rewrite these links which are hence not leading to content inside the ZIM.

These links should be considered for rewrite as well.

The result will of course depend on wether the redirect target is present inside the WARC/ZIM or not.

Which in turns depends on how the WARC has been built (i.e. did the system which built the WARC waited long enough to have the redirect target captured as well?) but this is beyond the scope of this issue / warc2zim. warc2zim must just ensure to consider these URLs for rewrite.

@benoit74
Copy link
Collaborator Author

I do not consider this is mandatory at all for Zimit2 release

@Jaifroid
Copy link

I do not consider this is mandatory at all for Zimit2 release

Agreed. It was an issue with the www.ready.gov ZIMs, but it did not affect systems reading the ZIM with the Replay ServiceWorker, because AFAIK the redirect was caught by the Service Worker (I may be wrong about that).

For zimit2, it's fine to deal with this empirically.

@kelson42 kelson42 added this to the 2.0.0 milestone Apr 18, 2024
@benoit74 benoit74 modified the milestones: 2.0.0, 2.1.0 May 13, 2024
@kelson42
Copy link
Contributor

I do not consider this is mandatory at all for Zimit2 release

@benoit74 Not a regression in comparison to Zimit1? It‘s also a pretty common scenario.

@benoit74
Copy link
Collaborator Author

Nope, not a regression AFAIK, it wasn't working in Zimit1 (hence the issue mentioned by Jaifroid on www.ready.gov)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants