Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly rewrite target url in HTML meta http-equiv redirect #353

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jul 18, 2024

Fix #237

Changes:

  • properly rewrite redirect target url when present in <meta> HTML tag
  • add test case in test website

Nota: this is built on-top of #343 and should hence be reviewed only once this is reviewed/merged

@benoit74 benoit74 self-assigned this Jul 18, 2024
@benoit74 benoit74 changed the title Meta http equiv redirect Correctly rewrite target url in HTTP meta http-equiv redirect Jul 18, 2024
@benoit74 benoit74 changed the title Correctly rewrite target url in HTTP meta http-equiv redirect Correctly rewrite target url in HTML meta http-equiv redirect Jul 23, 2024
@rgaudin rgaudin changed the base branch from main to open_html_rewriter July 26, 2024 15:25
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool! Lacks changelog entry

Base automatically changed from open_html_rewriter to main July 30, 2024 18:50
@benoit74 benoit74 marked this pull request as ready for review July 30, 2024 19:13
@benoit74 benoit74 merged commit 3327b57 into main Jul 30, 2024
5 checks passed
@benoit74 benoit74 deleted the meta_http_equiv_redirect branch July 30, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for redirection in meta http-equiv
2 participants