Merge pull request #302 from openzim/better-error-message

Improve an error message
openzim · May 9, 2022 · 9443091 · 9443091
2 parents 5b467b9 + 86923ba
commit 9443091
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/zimwriterfs/zimcreatorfs.cpp b/src/zimwriterfs/zimcreatorfs.cpp
@@ -278,7 +278,8 @@ std::string ZimCreatorFS::parseAndAdaptHtml(std::string& data, std::string& titl
  }
  }
 
- /* Detect if this is a redirection (if no redirects TSV file specified)
+ /* Detect if this is a HTML redirection (if no redirects TSV
+ file specified)
  */
  std::string targetUrl;
  try {
@@ -288,8 +289,10 @@ std::string ZimCreatorFS::parseAndAdaptHtml(std::string& data, std::string& titl
  }
  if (!targetUrl.empty()) {
  auto redirectUrl = computeAbsolutePath(url, decodeUrl(targetUrl));
- if (!fileExists(directoryPath + "/" + redirectUrl)) {
- throw std::runtime_error("Target path doesn't exists");
+ auto redirectUrlPath = directoryPath + "/" + redirectUrl;
+ if (!fileExists(redirectUrlPath)) {
+ throw std::runtime_error("'" + url + "' HTML redirection target path '"
+ + redirectUrlPath + "' doesn't exist.");
  }
  return redirectUrl;
  }