Zimbench command-line fixes #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 44.25% // Head: 44.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 44.25% 44.21% -0.04%
==========================================
Files 23 23
Lines 2368 2370 +2
Branches 1318 1319 +1
==========================================
Hits 1048 1048
- Misses 1304 1306 +2
Partials 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mgautierfr
approved these changes
Nov 1, 2022
mgautierfr
added a commit
that referenced
this pull request
Nov 30, 2022
* zimbench: Fix command line parsing (@veloman-yunkan #323)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322
This PR in its current form addresses only handling of unknown options. Support for long options was not added (rather the only long option
--nsand its associated short option-swere dropped because of being unused).