Empty links should not be errors (warnings only) #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
requested changes
Aug 10, 2023
src/zimcheck/checks.cpp
Outdated
| @@ -70,7 +71,7 @@ std::unordered_map<MsgId, MsgInfo> msgTable = { | |||
| { MsgId::MAIN_PAGE, { TestType::MAIN_PAGE, "Main Page Index stored in Archive Header: {{&main_page_index}}" } }, | |||
| { MsgId::EMPTY_ENTRY, { TestType::EMPTY, "Entry {{&path}} is empty" } }, | |||
| { MsgId::OUTOFBOUNDS_LINK, { TestType::URL_INTERNAL, "{{&link}} is out of bounds. Article: {{&path}}" } }, | |||
| { MsgId::EMPTY_LINKS, { TestType::URL_INTERNAL, "Found {{&count}} empty links in article: {{&path}}" } }, | |||
| { MsgId::EMPTY_LINKS, { TestType::URL_EMPTY, "Found {{&count}} empty links in article: {{&path}}" } }, | |||
There was a problem hiding this comment.
Please move this line up or down to regroup the URL_INTERNAL checks.
There was a problem hiding this comment.
Moved below URL_EXTERNAL
|
@BartlomiejZalas Thank you for your PR and last commit. Looks good, but might take a bit more than a week for the next review pass and merge. Thank you for your patience. |
kelson42
changed the title
mgautierfr
approved these changes
Aug 21, 2023
mgautierfr
force-pushed
the
issue-276/empty-links-should-not-be-errors
branch
from
133677d
to
17b718a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276.
URL_EMPTYintroduced (with warning severity)EMPTY_LINKSmoved from test typeURL_INTERNALtoURL_EMPTYTool usage output:
