Do not detect clone entry as duplicated content. #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 28.00% 27.93% -0.08%
==========================================
Files 26 26
Lines 2582 2585 +3
Branches 1373 1376 +3
==========================================
- Hits 723 722 -1
- Misses 1375 1376 +1
- Partials 484 487 +3 ☔ View full report in Codecov by Sentry. |
|
@mgautierfr Now that libzim |
veloman-yunkan
requested changes
Dec 18, 2023
mgautierfr
force-pushed
the
clone_check
branch
from
3a1b0ff
to
5fc96aa
Compare
|
Last comment fixed. |
veloman-yunkan
approved these changes
Dec 18, 2023
If two entries point to the same tuple (cluter_id, blob_id), we must not report them as duplicated content.
mgautierfr
force-pushed
the
clone_check
branch
from
5fc96aa
to
f3d38b3
Compare
|
CI for packages on debian unstable is failing because of a wrong version of libzim available. |
|
Fix #377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two entries point to the same tuple (cluter_id, blob_id), we must not report them as duplicated content.
Depends of openzim/libzim#833
Missing: Test of the check with a zim file actually containing clone entries.