Decoding of HTML entities in links

[veloman-yunkan]

Fixes #378

URI-decoding of links extracted from the HTML was performed, so I only had to add handling of HTML entities. I did so only for the syntactically important characters &, <, > and ".

[codecov]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (b8a0a4c) 27.49% compared to head (a9d0e1c) 28.06%.

Files	Patch %	Lines
src/tools.cpp	56.25%	5 Missing and 9 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   27.49%   28.06%   +0.57%     
==========================================
  Files          26       26              
  Lines        2550     2576      +26     
  Branches     1356     1371      +15     
==========================================
+ Hits          701      723      +22     
- Misses       1368     1369       +1     
- Partials      481      484       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mgautierfr]

Code LGTM.

But I have a doubt about limiting to the four &, <, > and ".
While I agree that the chars mostly encoded to not break html, we cannot assume we will not found other char html encoded.
In the same time the list of named character is pretty long, I agree we can wait & see if we need it.

@kelson42 ?

[kelson42]

@veloman-yunkan Any reason why ' has not been implemented like described in the ticket? The probably of something like href='http://www.kiwix.org/j'aime' seems quite high to me.

[kelson42]

@veloman-yunkan LGTM (thx for your quick fix)

[veloman-yunkan]

@veloman-yunkan Any reason why ' has not been implemented like described in the ticket? The probably of something like href='http://www.kiwix.org/j'aime' seems quite high to me.

@kelson42 My fault. Fixed now.

[veloman-yunkan]

@kelson42 Before merging, it always makes sense to have fixup commits (if any) squashed into their respective commits (via a rebase).

[kelson42]

My bad, sorry