Do not use std::optional.
#392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old compiler on aarch_64 doesn't support `std::optional` (sadly)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 27.93% 27.93%
=======================================
Files 26 26
Lines 2585 2585
Branches 1376 1376
=======================================
Hits 722 722
Misses 1376 1376
Partials 487 487 ☔ View full report in Codecov by Sentry. |
veloman-yunkan
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old compiler on aarch_64 doesn't support
std::optional(sadly)