Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name is a mandatory metadata #410

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Name is a mandatory metadata #410

merged 1 commit into from
Jun 2, 2024

Conversation

kelson42
Copy link
Contributor

Fixes #407

@kelson42 kelson42 requested a review from rgaudin May 27, 2024 11:14
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 26.97%. Comparing base (ffb02ff) to head (950495a).

Files Patch % Lines
src/zimwriterfs/zimwriterfs.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   26.97%   26.97%           
=======================================
  Files          26       26           
  Lines        2450     2450           
  Branches     1336     1336           
=======================================
  Hits          661      661           
  Misses       1302     1302           
  Partials      487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 663b9ca into main Jun 2, 2024
10 of 12 checks passed
@kelson42 kelson42 deleted the mandatory-name branch June 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name is incorrectly marked as optional
2 participants