Use warc2zim2 branch of warc2zim.
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`warc2zim2` branch create zim files without service worker.
benoit74
force-pushed
the
use_warc2zim2
branch
from
75f7a08
to
db411f8
Compare
benoit74
force-pushed
the
use_warc2zim2
branch
from
db411f8
to
a352c0c
Compare
|
@rgaudin could you please review again now that I've added the temporary Github workflow to build |
rgaudin
approved these changes
Jan 15, 2024
|
I had to force-push to update the base commit after the merge of #262 (and avoid strange Git history). And I did it before the review because the commits where quite obvious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need #262 to be merged first.