Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass scraper suffix to warc2zim #277

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Pass scraper suffix to warc2zim #277

merged 2 commits into from
Feb 5, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #275

@benoit74 benoit74 changed the base branch from main to zimit2 January 31, 2024 13:58
@benoit74 benoit74 marked this pull request as ready for review January 31, 2024 14:08
@benoit74 benoit74 requested a review from rgaudin January 31, 2024 14:09
@benoit74
Copy link
Collaborator Author

I forced-push a small change since I forgot to update the CHANGELOG

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (a505df9) 15.53% compared to head (9244f2e) 15.00%.
Report is 2 commits behind head on zimit2.

❗ Current head 9244f2e differs from pull request most recent head 49da57c. Consider uploading reports for the commit 49da57c to get more accurate results

Files Patch % Lines
src/zimit/zimit.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           zimit2     #277      +/-   ##
==========================================
- Coverage   15.53%   15.00%   -0.54%     
==========================================
  Files           1        1              
  Lines         251      260       +9     
  Branches       39       40       +1     
==========================================
  Hits           39       39              
- Misses        212      221       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/zimit/zimit.py Outdated Show resolved Hide resolved
src/zimit/zimit.py Outdated Show resolved Hide resolved
tests-integration/integration.py Outdated Show resolved Hide resolved
@benoit74 benoit74 requested a review from rgaudin February 5, 2024 13:40
@rgaudin rgaudin merged commit 7caa355 into zimit2 Feb 5, 2024
4 checks passed
@rgaudin rgaudin deleted the scraper_suffix branch February 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass scraper parameter to warc2zim
2 participants