Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test checking that expected entries are present #348

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Add test checking that expected entries are present #348

merged 2 commits into from
Aug 7, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #287

Changes:

  • assert that expect ZIM entries are present in the final ZIM of the integration tests

@benoit74 benoit74 self-assigned this Jul 19, 2024
@benoit74 benoit74 marked this pull request as ready for review July 22, 2024 07:20
rgaudin
rgaudin approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 751e104 into main Aug 7, 2024
5 checks passed
@benoit74 benoit74 deleted the assert_zim_entries branch August 7, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance integration test to assert final content of the ZIM
2 participants
@benoit74 @rgaudin