Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 29, 2024

Fixes: #1117

Lots of changes to the catalog test infrastructure, as I needed to include information about the catalog itself.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Lots of changes to the catalog test infrastructure, as I needed to
include information about the catalog itself.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner August 29, 2024 18:48
@netlify
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 361d5e6
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d0d4e145cc230008f4edb7
😎 Deploy Preview https://deploy-preview-1193--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (02d28b9) to head (361d5e6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
- Coverage   77.55%   77.27%   -0.29%     
==========================================
  Files          35       35              
  Lines        1916     1945      +29     
==========================================
+ Hits         1486     1503      +17     
- Misses        296      308      +12     
  Partials      134      134              
Flag Coverage Δ
e2e 58.71% <81.25%> (-0.06%) ⬇️
unit 54.85% <100.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Todd Short <tshort@redhat.com>
Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@dtfranz dtfranz added this pull request to the merge queue Aug 29, 2024
Merged via the queue into operator-framework:main with commit 04ee036 Aug 29, 2024
@tmshort tmshort deleted the priority branch August 29, 2024 21:46
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ClusterCatalog priority to operator-controller

2 participants