Bug 1952576: csv_succeeded metric not present

`csv_succeeded` metric is lost between pod restarts. This is because this metric is only emitted when CSV.Status is changed.
operator-framework · Jun 23, 2021 · 9bf9b01 · 9bf9b01
1 parent cd40303
commit 9bf9b01
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/controller/operators/olm/operator.go b/pkg/controller/operators/olm/operator.go
@@ -1115,11 +1115,12 @@ func (a *Operator) syncClusterServiceVersion(obj interface{}) (syncError error)
  } else {
  syncError = fmt.Errorf("error transitioning ClusterServiceVersion: %s and error updating CSV status: %s", syncError, updateErr)
  }
- } else {
- metrics.EmitCSVMetric(clusterServiceVersion, outCSV)
  }
  }
 
+ // always emit csv metrics
+ metrics.EmitCSVMetric(clusterServiceVersion, outCSV)
+
  operatorGroup := a.operatorGroupFromAnnotations(logger, clusterServiceVersion)
  if operatorGroup == nil {
  logger.WithField("reason", "no operatorgroup found for active CSV").Debug("skipping potential RBAC creation in target namespaces")