Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#59037] Primerize "Log time" dialog #17268

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

[#59037] Primerize "Log time" dialog #17268

wants to merge 16 commits into from
+522 −124

Conversation

klaustopher
Copy link
Contributor

@klaustopher klaustopher commented Nov 25, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/59037

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

ToDos

  • User input field generates the wrong input name for the hidden input. Should be time_entry[custom_field_values][14][] is timeentry[custom_field_values][14][]
  • User select adds an empty component wrapper for the hidden input field, this shows up in the UI as a seperator

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch 6 times, most recently from 7652116 to 40c2e5f Compare November 29, 2024 14:05
@klaustopher
[#59037] Primerize "Log time" dialog
d62fff0 
https://community.openproject.org/work_packages/59037
@klaustopher
cleanup: remove duplicated branch in CostlogController
d70cdc2
@klaustopher
add skeleton for TimeEntriesController
acc5589
@klaustopher
Add routes for time entry tracking
8ad7a3c
@klaustopher
Add a stub for the dialog
e012483
@klaustopher
Add a temporary link to log time to the project overview
2e87cd9
@klaustopher
temp: also add a link to edit a time entry
ec1491f
@klaustopher
Add body to the dialog and build a form
2802c9e
@klaustopher
extract logic to render custom fields into a concern
09800aa
@klaustopher
implement the form
4242348
@klaustopher
also change wrapper id to have it only in the project custom fields form
17a1117
@klaustopher
add call to super
89fc7eb
@klaustopher
add stimulus controller
75017a2
@klaustopher
fix generating input field names correctly for names with camelized n…
60f1771 
…ames
@klaustopher
correct filter search depending on object and add wrapper for dialog
f207f06
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 183f12e to f207f06 Compare November 29, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@klaustopher