From 82ff79760733d3dc44d715f95094a120195d8a08 Mon Sep 17 00:00:00 2001 From: Harshita Pandey Date: Fri, 13 Jan 2023 19:58:57 +0530 Subject: [PATCH 1/2] Comment for NVMeSubsystem Signed-off-by: Harshita Pandey --- goopicsi.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/goopicsi.go b/goopicsi.go index e1c6fe9..fcd509a 100644 --- a/goopicsi.go +++ b/goopicsi.go @@ -203,6 +203,8 @@ func ExposeRemoteNVMe(subsystemNQN string, maxNamespaces int64) (string, string, if err != nil { log.Printf("No existing NVMe Controller found with controllerID: %v", controllerID) } + + // Default value of MaxNamespaces is 32 incase the parameter is not assigned any value if data2 == nil { response2, err := client.CreateNVMeController(ctx, &pb.CreateNVMeControllerRequest{ NvMeController: &pb.NVMeController{ From d7ae63e85ea8d0ed99a7c88252df24dff8f54a9b Mon Sep 17 00:00:00 2001 From: Harshita Pandey Date: Fri, 13 Jan 2023 20:40:33 +0530 Subject: [PATCH 2/2] Adding Comment for ExposeRemoteNVMe Signed-off-by: Harshita Pandey --- goopicsi.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/goopicsi.go b/goopicsi.go index fcd509a..0612a8c 100644 --- a/goopicsi.go +++ b/goopicsi.go @@ -160,7 +160,7 @@ func NVMeControllerDisconnect(id string) error { return nil } -// ExposeRemoteNVMe creates a new NVMe Subsystem and NVMe controller +// ExposeRemoteNVMe creates a new NVMe Subsystem and NVMe controller. Default value of MaxNamespaces is 32 incase the parameter is not assigned any value func ExposeRemoteNVMe(subsystemNQN string, maxNamespaces int64) (string, string, error) { if conn == nil { err := dialConnection()