disabled editing for spec viewer #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if there's not a quick thing we can do to make that urge to edit sticky. Like have a call to action to visit the repo it came from or something |
|
Like an "edit on github" button? |
devdoshi
suggested changes
Sep 2, 2020
workspaces/ui/src/components/diff/v2/shape_viewers/ShapeOnlyShapeRows.js
Outdated
Show resolved
Hide resolved
ghost
reviewed
Sep 3, 2020
There was a problem hiding this comment.
This pull request has been automatically deployed to FeaturePeek. 👏
Your deployment will be kept up-to-date with this pull request's latest changes.
Please read our docs for more configuration details.
I like this idea, maybe if you click a field to edit it, you get a modal with instructions to clone and open it -- not perfect, but might be right for this stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Please merge this before #333 **
This is required for the release of GitBot.
This prohibits users from editing the public spec viewer site on apidocs.useoptic.com. Technically, they already couldn't (since we're not saving anything they do), but it feels like you can (until you refresh). Rather than confuse users, this PR ensures that no edits can happen.
This PR also does a quick refactor of the buildSpec process, moving common env vars into a
specReqsfile