From d8965dd48ab3ab774833d9cf3ef143f562ba5ee7 Mon Sep 17 00:00:00 2001 From: Pawel Szczodruch Date: Thu, 7 Nov 2019 13:36:31 -0800 Subject: [PATCH] fix: return right after datafile getter returns an error (don't parse garbage) --- pkg/config/polling_manager.go | 2 ++ pkg/config/static_manager.go | 1 + 2 files changed, 3 insertions(+) diff --git a/pkg/config/polling_manager.go b/pkg/config/polling_manager.go index 0f78f63fa..429a8ff5b 100644 --- a/pkg/config/polling_manager.go +++ b/pkg/config/polling_manager.go @@ -94,6 +94,8 @@ func (cm *PollingProjectConfigManager) SyncConfig(datafile []byte) { if e != nil { cmLogger.Error(fmt.Sprintf("request returned with http code=%d", code), e) + cm.err = e + return } } diff --git a/pkg/config/static_manager.go b/pkg/config/static_manager.go index dd5272e23..be8f46202 100644 --- a/pkg/config/static_manager.go +++ b/pkg/config/static_manager.go @@ -41,6 +41,7 @@ func NewStaticProjectConfigManagerFromURL(sdkKey string) (*StaticProjectConfigMa datafile, code, e := requester.Get() if e != nil { cmLogger.Error(fmt.Sprintf("request returned with http code=%d", code), e) + return nil, e } return NewStaticProjectConfigManagerFromPayload(datafile)