Skip to content

[FSSDK-9698] chore: prepare for patch release 1.8.5 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

[FSSDK-9698] chore: prepare for patch release 1.8.5 #382

merged 1 commit into from
Oct 5, 2023

Conversation

@pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented Oct 4, 2023 •
edited
Loading

Ticket:

@pulak-opti pulak-opti requested a review from a team as a code owner October 4, 2023 17:55
@pulak-opti pulak-opti changed the title chore: prepare for patch release 1.8.5 [FSSDK-9698] chore: prepare for patch release 1.8.5 Oct 4, 2023
mikechu-optimizely
mikechu-optimizely requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to make a release branch called 1.8.5 from the 1.8.4 branch, then cherry-pick your change from #374 into that?

You can then follow up on updating the CHANGELOG and bumping the /pkg/event/version.go#L21 per the release process Confluence. Just thinking 🤔 ...

I'm not sure if we want to merge into master since that's our beta currently, right?

@pulak-opti
Copy link
Contributor Author

pulak-opti commented Oct 5, 2023

Hey @mikechu-optimizely
We are exactly going to do so. We have a branch prepared here https://github.com/optimizely/go-sdk/tree/1.8.x for the 1.8.5 release. This PR is just intended to update the changelog and we should not update /pkg/event/version.go#L21 as this is not the latest release rather just a patch release of a previous version.

@pulak-opti pulak-opti merged commit 6c640ba into master Oct 5, 2023
@pulak-opti pulak-opti deleted the release-1.8.5 branch October 5, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@pulak-opti pulak-opti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pulak-opti @mikechu-optimizely