Fix imports to avoid anti-pattern

Author: yavorona

packages/optimizely-sdk/lib/core/decision_service/index.d.ts

@@ -16,9 +16,7 @@
 
 declare module '@optimizely/optimizely-sdk/lib/core/decision_service' {
   import { LogHandler } from '@optimizely/js-sdk-logging';
-  import { UserProfile, UserAttributes } from '@optimizely/optimizely-sdk';
-  import { ProjectConfig } from '@optimizely/optimizely-sdk/lib/core/project_config';
-  import { Experiment, Variation, FeatureFlag } from '@optimizely/optimizely-sdk/lib/core/project_config';
+  import { ProjectConfig, Experiment, Variation, FeatureFlag } from '@optimizely/optimizely-sdk/lib/core/project_config';
 
   export function createDecisionService(options: Options): DecisionService;
 
@@ -27,6 +25,12 @@ declare module '@optimizely/optimizely-sdk/lib/core/decision_service' {
     save(profile: UserProfile): void;
   }
 
+  export type UserAttributes = {
+    // TODO[OASIS-6649]: Don't use any type
+    // eslint-disable-next-line  @typescript-eslint/no-explicit-any
+    [name: string]: any;
+  }
+
   interface DecisionService {
     getVariation(experimentKey: string, userId: string, attributes?: UserAttributes): string | null;
     getVariationForFeature(configObj: ProjectConfig, feature: FeatureFlag, userId: string, attributes: unknown): Decision;
@@ -46,4 +50,14 @@ declare module '@optimizely/optimizely-sdk/lib/core/decision_service' {
     variation: Variation | null;
     decisionSource: string;
   }
+
+  // Information about past bucketing decisions for a user.
+  interface UserProfile {
+    user_id: string;
+    experiment_bucket_map: {
+      [experiment_id: string]: {
+        variation_id: string;
+      };
+    };
+  }
 }

packages/optimizely-sdk/lib/index.d.ts

@@ -17,6 +17,7 @@
 declare module '@optimizely/optimizely-sdk' {
   import { LogHandler, ErrorHandler } from '@optimizely/js-sdk-logging';
   import { Experiment, Variation } from '@optimizely/optimizely-sdk/lib/core/project_config';
+  import { UserProfileService, UserAttributes } from '@optimizely/optimizely-sdk/lib/core/decision_service';
   import * as enums from '@optimizely/optimizely-sdk/lib/utils/enums';
   import * as logging from '@optimizely/optimizely-sdk/lib/plugins/logger';
   export { enums, logging };
@@ -136,11 +137,6 @@ declare module '@optimizely/optimizely-sdk' {
     dispatchEvent: (event: Event, callback: () => void) => void;
   }
 
-  export interface UserProfileService {
-    lookup: (userId: string) => UserProfile;
-    save: (profile: UserProfile) => void;
-  }
-
   // NotificationCenter-related types
   export interface NotificationCenter {
     addNotificationListener<T extends ListenerPayload>(
@@ -165,12 +161,6 @@ declare module '@optimizely/optimizely-sdk' {
     logEvent: Event;
   }
 
-  export type UserAttributes = {
-    // TODO[OASIS-6649]: Don't use any type
-    // eslint-disable-next-line  @typescript-eslint/no-explicit-any
-    [name: string]: any;
-  };
-
   export type EventTags = {
     [key: string]: string | number | boolean;
   };
@@ -181,16 +171,6 @@ declare module '@optimizely/optimizely-sdk' {
     logEvent: Event;
   }
 
-  // Information about past bucketing decisions for a user.
-  export interface UserProfile {
-    user_id: string;
-    experiment_bucket_map: {
-      [experiment_id: string]: {
-        variation_id: string;
-      };
-    };
-  }
-
   /**
    * Optimizely Config Entities
    */