Skip to content

Commit f00a8ad

Browse files
committed
loading requirements from file
1 parent e9b1221 commit f00a8ad

File tree

4 files changed

+22
-31
lines changed

4 files changed

+22
-31
lines changed

opengrok-tools/pom.xml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,8 @@ Portions Copyright (c) 2017-2018, 2020, Chris Fraire <cfraire@me.com>.
152152
<includes>
153153
<include>MANIFEST.in</include>
154154
<include>README-dist.txt</include>
155+
<include>requirements.txt</include>
156+
<include>requirements-tests.txt</include>
155157
<include>setup.py</include>
156158
<include>setup.cfg</include>
157159
</includes>
@@ -224,9 +226,11 @@ Portions Copyright (c) 2017-2018, 2020, Chris Fraire <cfraire@me.com>.
224226
<execution>
225227
<id>Install requirements via pip</id>
226228
<configuration>
227-
<executable>${python.environment}/pip</executable>
229+
<executable>${python.environment}/python</executable>
228230
<workingDirectory>${project.build.directory}</workingDirectory>
229231
<arguments>
232+
<argument>-m</argument>
233+
<argument>pip</argument>
230234
<argument>install</argument>
231235
<argument>-r</argument>
232236
<argument>${project.basedir}/requirements.txt</argument>
@@ -240,12 +244,14 @@ Portions Copyright (c) 2017-2018, 2020, Chris Fraire <cfraire@me.com>.
240244
<execution>
241245
<id>Install test modules via pip</id>
242246
<configuration>
243-
<executable>${python.environment}/pip</executable>
247+
<executable>${python.environment}/python</executable>
244248
<workingDirectory>${project.build.directory}</workingDirectory>
245249
<arguments>
250+
<argument>-m</argument>
251+
<argument>pip</argument>
246252
<argument>install</argument>
247253
<argument>-r</argument>
248-
<argument>${project.basedir}/tests.txt</argument>
254+
<argument>${project.basedir}/requirements-tests.txt</argument>
249255
</arguments>
250256
</configuration>
251257
<phase>test</phase>
File renamed without changes.

opengrok-tools/requirements.txt

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
1-
certifi==2018.8.24
2-
chardet==3.0.4
3-
filelock==3.0.10
4-
idna==2.7
5-
JsonForm==0.0.2
61
jsonschema==2.6.0
7-
JsonSir==0.0.2
8-
Python-EasyConfig==0.1.7
9-
PyYAML==3.13
10-
requests==2.20.0
11-
Resource==0.2.1
12-
six==1.11.0
13-
urllib3==1.23
14-
GitPython==3.0.6
2+
pyyaml
3+
requests>=2.20.0
4+
resource
5+
filelock
6+
setuptools>=36.7.2

opengrok-tools/setup.py

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
23
from setuptools import setup
34

45
from src.main.python.opengrok_tools.version import __version__ as version
@@ -11,6 +12,11 @@ def readme():
1112
return readme.read()
1213

1314

15+
def readlines(file):
16+
with open(os.path.join(SCRIPT_DIR, file), 'r') as file:
17+
return list(map(str.strip, file.readlines()))
18+
19+
1420
setup(
1521
name='opengrok-tools',
1622
version=version,
@@ -31,25 +37,12 @@ def readme():
3137
description='Tools for managing OpenGrok instance',
3238
long_description=readme(),
3339
python_requires='>=3.4, <4',
34-
install_requires=[
35-
'jsonschema==2.6.0',
36-
'pyyaml',
37-
'requests>=2.20.0',
38-
'resource',
39-
'filelock',
40-
'setuptools>=36.7.2',
41-
],
40+
install_requires=readlines('requirements.txt'),
4241
setup_requires=[
4342
'pytest-runner',
4443
'setuptools>=36.7.2',
4544
],
46-
tests_require=[
47-
'pytest',
48-
'GitPython',
49-
'pytest-xdist',
50-
'mockito',
51-
'pytest-mockito',
52-
],
45+
tests_require=readlines('requirements-tests.txt'),
5346
entry_points={
5447
'console_scripts': [
5548
'opengrok-config-merge=opengrok_tools.config_merge:main',

0 commit comments

Comments
 (0)