Added validation error message for illegal channel name length as per Ryan's PR review comment.

Author: ankedia

operator/src/main/java/oracle/kubernetes/operator/helpers/PodStepContext.java

@@ -92,6 +92,7 @@
 import static oracle.kubernetes.operator.helpers.CompatibilityCheck.CompatibilityScope.UNKNOWN;
 import static oracle.kubernetes.operator.helpers.EventHelper.EventItem.DOMAIN_ROLL_STARTING;
 import static oracle.kubernetes.operator.helpers.EventHelper.EventItem.POD_CYCLE_STARTING;
+import static oracle.kubernetes.operator.helpers.LegalNames.LEGAL_CONTAINER_PORT_NAME_MAX_LENGTH;
 
 public abstract class PodStepContext extends BasePodStepContext {
 
@@ -314,7 +315,7 @@ private void addContainerPort(List<V1ContainerPort> ports, String name,
 
   private String createContainerPortName(List<V1ContainerPort> ports, String name) {
     //Container port names can be a maximum of 15 characters in length
-    if (name.length() > LegalNames.LEGAL_CONTAINER_PORT_NAME_MAX_LENGTH) {
+    if (name.length() > LEGAL_CONTAINER_PORT_NAME_MAX_LENGTH) {
       String portNamePrefix = getPortNamePrefix(name);
       // Find ports with the name having the same first 12 characters
       List<V1ContainerPort> containerPortsWithSamePrefix = ports.stream().filter(port ->
@@ -324,6 +325,10 @@ private String createContainerPortName(List<V1ContainerPort> ports, String name)
       // zero fill to the left for single digit index (e.g. 01)
       if (index < 10) {
         indexStr = "0" + index;
+      } else if (index >= 100) {
+        LOGGER.severe(MessageKeys.ILLEGAL_NETWORK_CHANNEL_NAME_LENGTH, getDomainUid(), getServerName(),
+                name, LEGAL_CONTAINER_PORT_NAME_MAX_LENGTH);
+        return name;
       }
       name = portNamePrefix + "-" + indexStr;
     }

operator/src/main/java/oracle/kubernetes/operator/logging/MessageKeys.java

@@ -144,7 +144,6 @@ public class MessageKeys {
   public static final String LOG_WAITING_COUNT = "WLSKO-0193";
   public static final String INTERNAL_IDENTITY_INITIALIZATION_FAILED = "WLSKO-0194";
 
-
   // domain status messages
   public static final String DUPLICATE_SERVER_NAME_FOUND = "WLSDO-0001";
   public static final String DUPLICATE_CLUSTER_NAME_FOUND = "WLSDO-0002";
@@ -177,6 +176,7 @@ public class MessageKeys {
   public static final String INVALID_LIVENESS_PROBE_SUCCESS_THRESHOLD_VALUE = "WLSDO-0029";
   public static final String RESERVED_CONTAINER_NAME = "WLSDO-0030";
   public static final String ILLEGAL_CONTAINER_PORT_NAME_LENGTH = "WLSDO-0031";
+  public static final String ILLEGAL_NETWORK_CHANNEL_NAME_LENGTH = "WLSDO-0032";
 
   private MessageKeys() {
   }

operator/src/main/resources/Operator.properties

@@ -185,6 +185,8 @@ WLSDO-0028=The Monitoring Exporter port ''{0}'' specified by ''spec.monitoringEx
 WLSDO-0029=Invalid value ''{0}'' for the liveness probe success threshold under ''{1}''. The liveness probe successThreshold value must be 1.
 WLSDO-0030=The container name ''{0}'' specified under ''{1}'' is reserved for use by the operator.
 WLSDO-0031=Container port name ''{2}'' for domain with domainUID ''{0}'' and container name ''{1}'' exceeds maximum allowed length ''{3}''.
+WLSDO-0032=Network channel name ''{2}'' for domain with domainUID ''{0}'' and server with \
+  name ''{1}'' exceeds maximum allowed length ''{3}''. Please specify a shorter channel name.
 
 oneEnvVar=variable
 multipleEnvVars=variables