From 5981d5cb086e6c5cc688122abee8d5ecc8f499e4 Mon Sep 17 00:00:00 2001
From: gram <git@orsinium.dev>
Date: Wed, 26 Oct 2022 11:18:52 +0200
Subject: [PATCH] do stable sync whenever possible

---
 mypy_baseline/commands/_sync.py | 39 ++++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/mypy_baseline/commands/_sync.py b/mypy_baseline/commands/_sync.py
index a87d026..b41cb02 100644
--- a/mypy_baseline/commands/_sync.py
+++ b/mypy_baseline/commands/_sync.py
@@ -9,6 +9,12 @@ class Sync(Command):
     """
 
     def run(self) -> int:
+        try:
+            baseline_text = self.config.baseline_path.read_text(encoding='utf8')
+        except FileNotFoundError:
+            baseline_text = ''
+        old_baseline = baseline_text.splitlines()
+
         baseline: list[str] = []
         for line in self.stdin:
             error = Error.new(line)
@@ -17,6 +23,37 @@ def run(self) -> int:
                 continue
             clean_line = error.get_clean_line(self.config)
             baseline.append(clean_line)
+
+        if old_baseline:
+            synced = self._stable_sync(old_baseline, baseline)
+        if not synced:
+            self._write_baseline(baseline)
+        return 0
+
+    def _stable_sync(self, old_bline: list[str], new_bline: list[str]) -> bool:
+        """Try to cleanly update the old baseline instead of rewriting it.
+
+        We do that to avoid lines jumping around that happens because of not ordered
+        output from mypy.
+
+        Currently, we can do a stable sync only when there are no new lines added.
+        It's hard to insert new lines in the correct positions, and adding them
+        at the end of the file will cause merge conflicts.
+        Sorting lines alphabetically would solve the issue, but I want to keep
+        backward compatibility.
+        """
+        old_set = set(old_bline)
+        new_set = set(new_bline)
+        removed = old_set - new_set
+        added = new_set - old_set
+        if added:
+            return False
+        result = [line for line in old_bline if line not in removed]
+        self._write_baseline(result)
+        return True
+
+    def _write_baseline(self, baseline: list[str]) -> None:
+        """Serialize baseline and write it into the file.
+        """
         serialized = '\n'.join(baseline) + '\n'
         self.config.baseline_path.write_text(serialized, encoding='utf8')
-        return 0