-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes RevokeHandler from JWT Introspector #155
Conversation
RevokeHandler has been removed because it conflicts with Stateless JWT accesstokens and revocable hmac refresh tokens. The readme has been updated to warn users about possible misconfiguration.
README.md
Outdated
@@ -335,6 +336,9 @@ Of course, fosite ships handlers for all OAuth2 and OpenID Connect flows. | |||
[Authentication using the Implicit Flow](http://openid.net/specs/openid-connect-core-1_0.html#ImplicitFlowAuth), | |||
[Authentication using the Hybrid Flow](http://openid.net/specs/openid-connect-core-1_0.html#HybridFlowAuth) | |||
|
|||
### JWT Introspection | |||
|
|||
Please note that when using the OAuth2StatelessJWTIntrospectionFactory access token revocation is not possible. | |||
|
|||
This section is missing documentation and we welcome any contributions in that direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be above the JWT introspection section, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean this line: "This section is missing documentation and we welcome any contributions in that direction." ? I thought it was a line belonging to the documentation chapter in general. If it was meant for the "Extensible handlers" then i'll move it above the "JWT Introspection".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it was menat for the handler section :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected in new push
Thank you so much for your continoous effort on these issues. One last thing, we have a DOC that you need to sign by doing |
Signed-off-by: Wesley Bos <wesley@dutchfrontiers.com>
Your welcome. I've signed off on it. I did force push it over the original but as nobody is dependent on it i don't think that is a problem. |
Yup, that's the way to go :) Thanks! |
* Removes RevokeHandler from JWT Introspector RevokeHandler has been removed because it conflicts with Stateless JWT accesstokens and revocable hmac refresh tokens. The readme has been updated to warn users about possible misconfiguration. * Moves text back to correct section Signed-off-by: Wesley Bos <wesley@dutchfrontiers.com>
RevokeHandler has been removed because it conflicts with Stateless JWT
accesstokens and revocable hmac refresh tokens. The readme has been
updated to warn users about possible misconfiguration.
Closes 154