fix: All responses now contain headers to not cache them #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitar
force-pushed
the
no-response-caching
branch
from
60b4754 to
200e37d
Compare
|
Thank you! |
|
I was again fooled by CircleCI not running. The tests are actually broken on master, can you please address the broken changes? I will now enforce CI runs for merges on master, which means that we need to figure out why CircleCI is not running on your fork or I won't be able to merge your PRs any more :( |
|
I will check. Sorry. Have you seen this comment? |
|
Done: #466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Based on https://openid.net/specs/openid-connect-core-1_0.html (non-normative examples) it looks like all responses include headers to prevent caching. I think this is reasonable. I do not see why any of OAuth responses would ever be cached.
So I just went through everything and added those headers.
Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.