Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sqa metrics v2 #3533

Merged
merged 5 commits into from
Jun 13, 2023
Merged

feat: sqa metrics v2 #3533

merged 5 commits into from
Jun 13, 2023

Conversation

misamu
Copy link
Contributor

@misamu misamu commented Jun 2, 2023

SQA metrics V2 payloads

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@misamu misamu requested a review from aeneasr as a code owner June 2, 2023 12:47
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #3533 (f45e8d0) into master (262ebbb) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head f45e8d0 differs from pull request most recent head 676d765. Consider uploading reports for the commit 676d765 to get more accurate results

@@           Coverage Diff           @@
##           master    #3533   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files         128      128           
  Lines        9509     9506    -3     
=======================================
- Hits         7286     7284    -2     
+ Misses       1731     1729    -2     
- Partials      492      493    +1     
Impacted Files Coverage Δ
cmd/server/handler.go 1.38% <0.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

cmd/server/handler.go Outdated Show resolved Hide resolved
aeneasr
aeneasr previously approved these changes Jun 7, 2023
# Conflicts:
#	cmd/server/handler.go
#	go.mod
#	go.sum
@zepatrik zepatrik merged commit 3ec683d into ory:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants