Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename iso -> anaconda-iso #165

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

cgwalters
Copy link
Contributor

@cgwalters cgwalters commented Jan 31, 2024

This PR just renames the iso artifact to anaconda-iso.

The reason is that I would like to potentially introduce a different generic "live iso" that generates exactly the input container just as a Live ISO, very similar to how Fedora CoreOS (and one of its parents, the original Container Linux) do it.

This (proposed) live-iso would have several use cases, such as always running from a PXE boot. I also think this is the long term architecture for an ISO, as opposed to the current Anaconda. It would also be the same as how e.g. Fedora Workstation does it, where the installer is just an app in the system.

Anyways again, this is just a rename. For compatibility we continue to honor the iso as an alias.

mvo5
mvo5 previously approved these changes Jan 31, 2024
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@noelmiller
Copy link

@cgwalters Just to clarify, Are you saying this would be a live ISO that you could use to install to disk using anconda from a live system rather than having an automated install with a kickstart file like it currently is now?

@cgwalters
Copy link
Contributor Author

This PR is just changing the name of the existing artifact.

But yes the new ISO type I am proposing would support what you are talking about. (Though there's some nontrivial details here, like to have the GUI anaconda I think we should embed it really as a flatpak etc.)

There is however some steps to bridge things here...if we support configuring the kickstart for our existing anaconda-iso (in particular, leaving off things like the partitioning) then I think it automatically kicks anaconda into interactive mode. (But yeah this is still not what one wants...IMO for honestly any case, but there's just a huge amount of Fedora-derivative inertia around Anaconda as it is going on here)

@noelmiller
Copy link

noelmiller commented Jan 31, 2024

This PR is just changing the name of the existing artifact.

But yes the new ISO type I am proposing would support what you are talking about. (Though there's some nontrivial details here, like to have the GUI anaconda I think we should embed it really as a flatpak etc.)

There is however some steps to bridge things here...if we support configuring the kickstart for our existing anaconda-iso (in particular, leaving off things like the partitioning) then I think it automatically kicks anaconda into interactive mode. (But yeah this is still not what one wants...IMO for honestly any case, but there's just a huge amount of Fedora-derivative inertia around Anaconda as it is going on here)

I think the benefit I see to having an Anaconda interactive mode (allowing for user creation, etc.) is it allows bootc-image-builder to support building things like Silverblue Custom ISOs or Universal Blue ISO images which would be hugely helpful to the Desktop Linux community.

Being able to use this tool to build desktop ISO images would be so cool!

@cgwalters
Copy link
Contributor Author

Hm tmt tests fell over with

E ModuleNotFoundError: No module named 'qmp'

which is surely unrelated?

Will look...

(Side note, I am just not a fan of dynamic languages anymore...and tangentially related to this was looking at refactoring the qemu Go wrapper we have in coreos-assembler (see coreos/coreos-assembler#3712 ) so that in theory it can be shared and reused with podman-machine)

Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks fine to me

@mvo5
Copy link
Collaborator

mvo5 commented Feb 8, 2024

Hm tmt tests fell over with

E ModuleNotFoundError: No module named 'qmp'

which is surely unrelated?

Will look...

(Side note, I am just not a fan of dynamic languages anymore...and tangentially related to this was looking at refactoring the qemu Go wrapper we have in coreos-assembler (see coreos/coreos-assembler#3712 ) so that in theory it can be shared and reused with podman-machine)

Fwiw, I agree and would love to use rust/go more …

@cgwalters
Copy link
Contributor Author

Hmm some strange failures in the testing farm job there:

Error: quay.io/centos-bootc/centos-bootc:stream9: image not known
test/test_build.py::test_image_boots[quay.io/centos-bootc/centos-bootc:stream9,qcow2] 7lSeaBIOS (version 1.15.0-1)


iPXE (https://ipxe.org/) 00:03.0 CA00 PCI2.10 PnP PMM+7CF8B470+7CECB470 CA00
Press Ctrl-B to configure iPXE (PCI 00:03.0)...
                                                                               


Booting from Hard Disk...
GRUB loading..
Welcome to GRUB!

qemu-system-x86_64: Slirp: Failed to send packet, ret: -1
error: ../../grub-core/disk/i386/pc/biosdisk.c:543:failure reading sector

I would like to potentially introduce a generic "live iso" that
generates *exactly the input container* just as a Live ISO, very
similar to how Fedora CoreOS (and one of its parents, the original
Container Linux) do it.

This has several use cases, such as always running from a PXE
boot.  I also think this is the long term architecture for an ISO,
as opposed to the current Anaconda.

This "direct" Live ISO is also the same as how e.g. Fedora Workstation
does it, where the installer is just an app in the system.

For compatibility we continue to honor the `iso` as an alias.
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think I'd prefer something that includes the word installer in it, to signify purpose, but names are hard.

@achilleas-k achilleas-k added this pull request to the merge queue Feb 15, 2024
Merged via the queue into osbuild:main with commit d08d1bf Feb 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants