Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueprint: remove the sshkey customization #928

Merged
merged 2 commits into from
Sep 16, 2024
Merged

blueprint: remove the sshkey customization #928

merged 2 commits into from
Sep 16, 2024

Commits on Sep 13, 2024

  1. blueprint: remove the sshkey customization 

    Both the sshkey and users customizations have been around since the
beginning of time [1].  The users customization was always a superset of
the sshkey, so we have code in blueprints to convert sshkeys into users.

The blueprint code in images is not exposed directly to users.  The code
responsible for deserializing blueprint toml files lives in
osbuild-composer and is directly translated to the equivalent types in
osbuild/images.  We can simplify the code and types here to only contain
the customizations that are strictly necessary and we don't need to
maintain backwards compatibility.

The blueprint conversion code in osbuild-composer should convert all
sshkeys to users before passing them down to osbuild/images functions.

[1] 967b0e8
    @achilleas-k
    achilleas-k committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cb5a9ae View commit details
    Browse the repository at this point in the history

  2. test: update test configs 

    Move sshkey in test configs to users.

This has no effect on generated manifests.
    @achilleas-k
    achilleas-k committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2d9ca58 View commit details
    Browse the repository at this point in the history