fix: Fix the ninjacookie call (#116)

Fix ninjacookie call and improve the release workflow.
osl-incubator · Jun 10, 2023 · 8bd413c · 8bd413c
1 parent b18c93e
commit 8bd413c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -38,13 +38,13 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: makim release.dry
 
-      # - name: Run semantic release
-      #   if: ${{ github.event_name == 'workflow_dispatch' }}
-      #   env:
-      #     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      #   run: |
-      #     poetry config pypi-token.pypi ${PYPI_TOKEN}
-      #     makim release.ci
+      - name: Run semantic release
+        if: ${{ github.event_name == 'workflow_dispatch' }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          poetry config pypi-token.pypi ${PYPI_TOKEN}
+          makim release.ci
 
       - name: Generate documentation with changes from semantic-release
         run: makim docs.build

diff --git a/src/scicookie/cli.py b/src/scicookie/cli.py
@@ -67,7 +67,7 @@ def call_cookiecutter(profile: Profile, answers: dict):
             answers_profile[choice_id] = "yes"
 
     for question_id, answer in answers_profile.items():
-        cookie_args.append(f'{question_id}="{answer}"')
+        cookie_args.append(f"{question_id}={answer}")
 
     sh_extras = {
         "_in": sys.stdin,
@@ -79,9 +79,7 @@ def call_cookiecutter(profile: Profile, answers: dict):
         "_bg_exc": False,
     }
 
-    p = sh.cookieninja(
-        "--no-input", PACKAGE_PATH, *[" ".join(cookie_args)], **sh_extras
-    )
+    p = sh.cookieninja("--no-input", PACKAGE_PATH, *cookie_args, **sh_extras)
 
     try:
         p.wait()