-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): Adding setuptools as a build-system option #140
Conversation
@xmnlab In tests/smoke/base.sh there is the same for setuptools as in meson, do I leave it as it is now or change it to |
feel free to keep it .. as both are the same .. it is not a problem .. thanks |
@Anavelyz in general looks good to me. as setuptool is kind the legacy because in the past we just used to use setuptools and maybe also it is used as dependency for the other build-system, let's use it in the |
Co-authored-by: Ivan Ogasawara <ivan.ogasawara@gmail.com>
thanks @Anavelyz |
@xmnlab In the future, for setuptools, we can add the options to configure it through setup.cfg or setup.py. |
@Anavelyz I hear you, but my impression is that the community is trying to kill setuptools ... so maybe first it would be nice to see if it would be worthy or not |
🎉 This PR is included in version 0.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
setuptools-pyproject.toml
.post_gen_project.py
.noqa
in profile.py to ignore ruff warningsSolve #53
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Reviewer's Checklist
main
branch