Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Circle Ci to the template #306

Merged
merged 15 commits into from
Oct 4, 2024

Conversation

Anavelyz
Copy link
Collaborator

@Anavelyz Anavelyz commented Jul 22, 2024

Pull Request description

Fixes #265

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@Anavelyz
Copy link
Collaborator Author

@xmnlab can you check it? Particularly config.yaml, please.

@xmnlab
Copy link
Member

xmnlab commented Aug 1, 2024

@Anavelyz , in general it looks nice .. but we need to add some validation in the smoke test when circleci is selected

could you check this option please? https://support.circleci.com/hc/en-us/articles/360006735753-How-to-validate-your-CircleCI-configuration

if you can try it locally and that works, I can create a api token to add it to the CI

@Anavelyz Anavelyz force-pushed the 265-add-circle-ci-template branch 2 times, most recently from 6ff97da to 4ac70bb Compare August 16, 2024 18:02
@Anavelyz Anavelyz force-pushed the 265-add-circle-ci-template branch from 83e45c4 to 80ad7a8 Compare September 11, 2024 18:58
@Anavelyz Anavelyz force-pushed the 265-add-circle-ci-template branch from 0a86e9d to 66ac8fd Compare September 28, 2024 12:40
@Anavelyz Anavelyz marked this pull request as ready for review September 29, 2024 23:08
.github/workflows/main.yaml Outdated Show resolved Hide resolved
@Anavelyz Anavelyz force-pushed the 265-add-circle-ci-template branch from 4e3ade9 to 882040d Compare October 2, 2024 17:06
@EverVino
Copy link

EverVino commented Oct 4, 2024

@xmnlab This Scicookie PR is ready for next round review

@xmnlab xmnlab merged commit ecf5b1c into osl-incubator:main Oct 4, 2024
20 checks passed
@xmnlab
Copy link
Member

xmnlab commented Oct 4, 2024

Thank you @Anavelyz for your hard work on this PR.
Thank you @EverVino for all the help !

Copy link

🎉 This PR is included in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add circle ci to the template
3 participants