Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): Updating quarto-cli and quartodoc versions and pin griffe version #310

Merged

Conversation

Anavelyz
Copy link
Collaborator

Pull Request description

Recently, griffe had been updated. It is cause to get the following error:

ModuleNotFoundError: No module named 'griffe.loader'

I restrict the version of griffe for it works fine, when quartodoc is updated it should be removed.

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved

@Anavelyz Anavelyz requested a review from xmnlab August 16, 2024 16:32
@Anavelyz Anavelyz force-pushed the set-griffe-version-for-quarto-work branch from f8aab5a to 81e60ff Compare August 16, 2024 16:47
@xmnlab xmnlab merged commit e0ccc0c into osl-incubator:main Aug 16, 2024
19 checks passed
Copy link

🎉 This PR is included in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants