Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Autogeneration api documentation files for mkdocs #311

Merged
merged 17 commits into from
Sep 11, 2024

Conversation

YurelyCamacho
Copy link
Collaborator

Pull Request description

Auto generation api documentation files for mkdocs

Fixes #309

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved

@YurelyCamacho YurelyCamacho requested a review from xmnlab August 26, 2024 19:31
@@ -5,6 +5,9 @@ channels:
dependencies:
- python >=3.8.1,<4
- pip
- pip:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pip: section should be at the end of the file and should be included just in the case that the build_system is poetry and the doc engine is mkdocs

@YurelyCamacho YurelyCamacho requested a review from xmnlab August 28, 2024 22:09
@YurelyCamacho
Copy link
Collaborator Author

@xmnlab In local makim tests.unittest runs correctly and here it doesn't work. I don't understand the problem with the paginate installation either.

@xmnlab
Copy link
Member

xmnlab commented Aug 29, 2024

oh .. the issue is not inside the tests .. it is in the CI job installation:

https://github.com/osl-incubator/scicookie/actions/runs/10604910289/job/29392594957?pr=311#step:4:83

it happens probably because there is a new release of paginate, and conda install it, but during the installation with poetry, it installs the previous version

pin the previous version (0.5.6) here https://github.com/osl-incubator/scicookie/blob/main/conda/dev.yaml#L15

@YurelyCamacho
Copy link
Collaborator Author

@xmnlab I need your help, I have solved several problems that have arisen and now this appears. It is with respect to the build package, in local it shows me:
Could not solve for environment specs The following package could not be installed └─ build does not exist (perhaps a typo or a missing channel).

@xmnlab
Copy link
Member

xmnlab commented Sep 4, 2024

Coul you open a new PR with no changes .. just to check if the ci is working?

You can create a commit with a flag called --allow-empty

@YurelyCamacho
Copy link
Collaborator Author

YurelyCamacho commented Sep 4, 2024

@xmnlab I did it and the IC does not work.
Check this out: https://conda.anaconda.org/conda-forge/linux-64/

@YurelyCamacho YurelyCamacho marked this pull request as ready for review September 5, 2024 15:56
@YurelyCamacho
Copy link
Collaborator Author

@xmnlab After several details the CI is running.
I have a doubt about the scripts folder, should it appear only when mkdocs is selected or is it ok like that.

@xmnlab
Copy link
Member

xmnlab commented Sep 6, 2024

Great! Yep, for now it is just used by mkdocs .. otherwise it shpuld be removed

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @YurelyCamacho !

@xmnlab xmnlab merged commit 10ceb0e into osl-incubator:main Sep 11, 2024
19 checks passed
Copy link

🎉 This PR is included in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template: use auto generation api documentation files for mkdocs
2 participants