Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): Removing griffe restriction #312

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Anavelyz
Copy link
Collaborator

@Anavelyz Anavelyz commented Sep 4, 2024

Pull Request description

There was a restriction on griffe because quartodoc wasn't working, now it works fine, this restriction is removed here because it's not necessary.

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved

@Anavelyz Anavelyz force-pushed the remove-griff-restriction branch from 4f848a1 to 16ebaa5 Compare September 5, 2024 13:16
@Anavelyz Anavelyz requested a review from xmnlab September 5, 2024 13:40
@xmnlab xmnlab merged commit 37c65c4 into osl-incubator:main Sep 5, 2024
19 checks passed
Copy link

🎉 This PR is included in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants