-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(project information): adding missing information #149
Conversation
@xmnlab In the case of setuptools, Do you consider it necessary to add this?: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html Thanks @Anavelyz for your comment |
@YurelyCamacho could you give me more details about this? |
I mean .. about your question |
@YurelyCamacho in general it looks great! thanks for working on that.
so basically, what that means is that at the end scicookie is not using the values specified in the inputs .. it uses just the default values .. for example if I type for the name "Luffy" at the end the ouput project will have "Rorona Zoro", instead of Luffy. if you generate a new project, check the pyproject file and the git history inside the project with could you check if that was resolved or if you can still see that issue please? |
also, I am totally fine to merge this PR as it is, and you can work on a follow-up to address the other points if anything else is missing. |
oh just saw that you already mentioned about that in your initial comments. |
🎉 This PR is included in version 0.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
Adding missing information after the project creation and fix bugs 3/5
pyproject.toml
packages
entry inpyproject.toml
Solve #147
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Reviewer's Checklist
main
branch