Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve pyproject.toml output and keep workflow more consistent #277

Merged
merged 10 commits into from
May 4, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented May 3, 2024

Pull Request description

  • organize build-system files into folders, one folder for each build-system
  • add test to check if the package is importable and if it shows the correct version using __version__ (not working yet for mesonpy and maturin)
  • standardize cpp file names
  • fix the structure in the final version of pyproject.toml
  • fix some issues with some build system configurations
  • fix the end of file in the post generation hook

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab xmnlab merged commit b2cc87d into osl-incubator:main May 4, 2024
13 checks passed
@xmnlab xmnlab deleted the improve-pyproject branch May 4, 2024 16:19
Copy link

🎉 This PR is included in version 0.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant