Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modularized AwsModal, deleted unnecessary code in other modals #10

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

stephenhyang
Copy link

References issue #. Please review this @teammember1, @teamMember2.

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • [ x ] Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would cause existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Modularized AwsModal to make component more readable and clear.
  • Deleted unnecessary code in other Modal files so components are easier to visualize

Approach

  • Created three child components for AwsModal called, AwsServiceInstance, AwsRegion, AwsKeyUrl, and AwsDescription
  • Passed down props necessary for child components to render
  • Deleted code in Modal files that were not necessary for our functionality

Screens

Screenshot 2024-04-30 at 3 33 01 PM hot(s)

@sarhiri sarhiri merged commit ac3ec98 into dev Apr 30, 2024
@mdtagg mdtagg deleted the stephenfeature branch April 30, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants