Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functional select all services button #24

Merged
merged 3 commits into from
May 11, 2024
Merged

New functional select all services button #24

merged 3 commits into from
May 11, 2024

Conversation

stephenhyang
Copy link

References issue #. Please review this @teammember1, @teamMember2.

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would cause existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Allow users option to select all services
  • Make modal components more readable

Approach

  • Added button that selects all services on ServicesModal
  • Styled button so that it matches theme of ServicesModal
  • Deconstructed props from all modals components
  • Removed unnecessary console logs

Screenshot(s)

Screenshot 2024-05-11 at 10 56 33 AM

@mdtagg
Copy link
Collaborator

mdtagg commented May 11, 2024

Thanks for adding the select all services functionality! Nice job Stephen

@mdtagg mdtagg merged commit f2168fd into dev May 11, 2024
@stephenhyang stephenhyang changed the title Stephenfeature New functional select all services button May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants