Graph container/refactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nav was extracted for readabilty purposes. Attempting to separate the concerns in the graph container and increase understandability
The string to colour function was moved to facilitate easier navigation of the graph container. Additionally since it is only a function and not a react FC it could be imoprted into the three components that use it instead of passed down as props. Doing this added some simplicity to the types in the props
Charts are now conditionally rendered with a ternary instead of individal truthy checks to increase readablity and dryness of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References issue #. Please review this @TedPham397 @stephenhyang @sarhiri .
Types of changes
Purpose
-broke up graphs container into separate components for readability and to seperate concerns
Learning
Screenshot(s)