-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USPS Standard Suffix Abbreviation #3414
base: master
Are you sure you want to change the base?
Conversation
Some entries have the same source and destination text, e.g.
|
@mtmail Some of the duplicates were present before my contribution--should I remove them altogether? |
@mhsr21 Would be great if you can remove the other duplicates, too. I see 42, and 41 of those are in the cat settings/icu-rules/variants-* | perl -ne '/^\s+-\s+(.+?)\s+->\s+(.+)/ && $1 eq $2 && print' | wc -l
42 |
@mtmail Got rid of all duplicates in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through this. I agree that we should have official abbreviations in this list.
On a more general note, the US abbreviation list has always had the problem that it is far too long. In particular, it has the problem that it proposes sometimes 3 or 4 variants for the same word. This has a negative effect on the size of the index. Would it make sense to restrict ourselves to the official abbreviations only or are the other ones are just as frequently used?
settings/icu-rules/variants-en.yaml
Outdated
- Spur -> Spur | ||
- Spring -> Spg | ||
- Springs -> Spgs | ||
- SPurs -> Spur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo here.
I only added the official abbreviations (the rightmost column on the linked website). |
Added USPS's Standard Suffix Abbreviation for postal addressing (https://pe.usps.com/text/pub28/28apc_002.htm)