Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanmibank #4990

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Hanmibank #4990

merged 2 commits into from
Mar 24, 2021

Conversation

m-hue
Copy link
Collaborator

@m-hue m-hue commented Mar 24, 2021

Bank with locations in CA, IL, NJ, NY, TX and VA.

@LaoshuBaby
Copy link
Collaborator

I trying to find more exact states boundry in country coder but failed.

So I think this is exact enough.

@LaoshuBaby
Copy link
Collaborator

Thanks @m-hue for improving NSI continuosly!

@LaoshuBaby LaoshuBaby merged commit 92c21e5 into osmlab:main Mar 24, 2021
@m-hue m-hue deleted the hanmibank branch March 25, 2021 16:54
@LaoshuBaby
Copy link
Collaborator

Can this locationSet suitable for using geojson to describe?

(Because just received the comment notice for #4784

@bhousel
Copy link
Member

bhousel commented Mar 28, 2021

Can this locationSet suitable for using geojson to describe?

We don't have state-level boundaries yet, but scoping it to us (or even conus) is ok for now.

Hanmibank might expand to more states, and it would be extra work for us to maintain a geojson of all the states where its branches are.

@LaoshuBaby
Copy link
Collaborator

Can this locationSet suitable for using geojson to describe?

We don't have state-level boundaries yet, but scoping it to us (or even conus) is ok for now.

Hanmibank might expand to more states, and it would be extra work for us to maintain a geojson of all the states where its branches are.

So since there is currently no geojson file for continents, it seems that I have been worrying too much. Thank @bhousel for your answer! 👍

@bhousel
Copy link
Member

bhousel commented Mar 28, 2021

So since there is currently no geojson file for continents, it seems that I have been worrying too much. Thank @bhousel for your answer! 👍

yes, for locationSet we can support:

  • codes recognized by country-coder - https://ideditor.codes
  • circle region defined as a point and radius
  • custom .geojson file

(more info here: https://github.com/ideditor/location-conflation/blob/main/README.md )

It's somewhat expensive to download or bundle a lot of geojsons, and also extra work for us to maintain them, so I think of it as a fallback option.. They are very useful for sub-country regions like Crimea, or French-speaking Canada, or regions where transit companies operate, etc. We also have a few situations in the US where there are separate regional brands using the same name ("Price Chopper", "Citizens Bank").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants