Adding many Mexican items #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
reviewed
Jul 25, 2022
LaoshuBaby
reviewed
Jul 26, 2022
|
And for adding geojson, this may reqiure more maintainer's advice, (I'm only a junior maintainer who repeats simple work, may not be allow to participate for significant issues), to speed things fast I suggest you split this PR to 2, a geojson PR and a brand PR. Because looks like you haven’t using them in this PR. and I think the geojson you provided may be too detailed. FYI: #4784 |
LaoshuBaby
reviewed
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I've added and fixed some brands, and added geojson files for Mexican states.