Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests/e2e]: simplify the logic for adding accounts to genesis sdk side and integrate into e2e #1628

Closed
p0mvn opened this issue May 31, 2022 · 2 comments · Fixed by #4217 or #4706
Closed
Assignees
Labels

Comments

@p0mvn
Copy link
Member

p0mvn commented May 31, 2022

Background

We should simplify the process of adding accounts to genesis on the SDK side to improve readability in e2e set up. This issue includes making additions to our SDK fork, updating the dependency in osmosis, and, eventually, adding it to our e2e set up.

Please follow this comment for more information: #1625 (comment)_

Acceptance Criteria

  • investigate an easier way to add accounts to genesis
  • implement the improvement in Osmosis's SDK fork and unit test
  • update the sdk dependency in Osmosis's go.mod
  • refactor e2e set up to utilize the simpler method
@p0mvn
Copy link
Member Author

p0mvn commented Jan 25, 2023

What needs to be done is the following:

@p0mvn p0mvn added the C:e2e label Jan 25, 2023
@p0mvn p0mvn moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development Jan 25, 2023
@p0mvn p0mvn moved this from Todo 🕒 to Needs Review 🔍 in Osmosis Chain Development Jan 25, 2023
@p0mvn p0mvn moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development Jan 25, 2023
@ThanhNhann ThanhNhann self-assigned this Jan 30, 2023
@ThanhNhann ThanhNhann moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Feb 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Mar 6, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Mar 6, 2023

Reopining for the fix to follow-up on the following CI failure: https://github.com/osmosis-labs/osmosis/actions/runs/4338982856/jobs/7576658435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment