Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Rate Limiting #2305

Closed
2 tasks
nicolaslara opened this issue Aug 4, 2022 · 2 comments
Closed
2 tasks

IBC Rate Limiting #2305

nicolaslara opened this issue Aug 4, 2022 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@nicolaslara
Copy link
Contributor

Background

In the event of a chain exploit on osmosis or another chain connected via IBC, an attacker may want to quickly move the funds off osmosis (or into osmosis in the case of an infinite mint). To mitigate this, IBC channels should have a rate limiting capability so that no more than a pre-established amount can be moved through the channel

Suggested Design

Create a cosmwasm contract that keeps track of the balance moved through the bridge during a period of time and allows or denies IBC messages. Add an IBC middleware that calls the contract and forwards the messages in the case of success or fails when rate limiting.

Acceptance Criteria

  • Test for the middleware are comprehensive and pass
  • Test for the contract are comprehensive and pass
@nicolaslara nicolaslara added the feature New feature or request label Aug 4, 2022
@nicolaslara nicolaslara self-assigned this Aug 4, 2022
@nicolaslara nicolaslara moved this to Needs Review 🔍 in Osmosis Chain Development Aug 4, 2022
@nicolaslara nicolaslara moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development Aug 4, 2022
@nicolaslara nicolaslara moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Aug 4, 2022
@hiromaily
Copy link

I have a question about why this contract is created by cosmwasm, not basic golang code.

@ValarDragon
Copy link
Member

So it can be upgraded without a chain upgrade!

Closing this as IBC rate limiting has gotten into v13

Repository owner moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants