Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation testing against Tax-Calculator in TB release #447

Closed
MattHJensen opened this issue Jan 6, 2017 · 3 comments
Closed

validation testing against Tax-Calculator in TB release #447

MattHJensen opened this issue Jan 6, 2017 · 3 comments

Comments

@MattHJensen
Copy link
Contributor

MattHJensen commented Jan 6, 2017

PSLmodels/Tax-Calculator#1119 indicates that the TaxBrain release process could benefit from (more) validation testing against Tax-Calculator.

The baseline results from TaxBrain should be extremely close to those in the pufcsv_agg_expect.txt that the Tax-Calculator team generates from the requires_pufcsv tests.

One option would be to compare against those results with a tolerance. Another would be to add new requires_pufcsv tests that generate a dropq baseline.

@talumbau, what do you think?

@MattHJensen
Copy link
Contributor Author

@hdoupe, do you think this issue should remain open?

@hdoupe
Copy link
Collaborator

hdoupe commented Sep 8, 2017

@MattHJensen, I am working on similar tests in PR #627. This issue could be closed in favor of #615 and #602.

@MattHJensen
Copy link
Contributor Author

Thanks @hdoupe. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants