Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better quick sample settings #574

Closed
martinholmer opened this issue Jun 28, 2017 · 1 comment
Closed

Better quick sample settings #574

martinholmer opened this issue Jun 28, 2017 · 1 comment

Comments

@martinholmer
Copy link
Contributor

Beginning with the new puf.csv file used by Tax-Calculator release 0.9.0, we have found that the old quick-sample settings being used by TaxBrain are no longer very good.

The old settings were to use a random-number seed of 80 and a 0.02 (two percent) sample.
With the old puf.csv file that produced sample results that were within plus/minus one percent of the full sample tax revenues.

But using these old settings with the new puf.csv file produces differences of more than plus/minus one percent in every year with the largest difference being over 2.8 percent.

We have found that changing the settings to a random-number seed of 180 and a sampling fraction of 0.05 (five percent) restores the old situation in which the sample results are within plus/minus one percent of the full sample tax revenues. For more details, see Tax-Calculator pull request 1441.

It seems as if TaxBrain users who use this feature (if there are any) are going to notice this change. So, it would seem like a simple enhancement to change the settings to 180 and 0.05.

@MattHJensen @feenberg @GoFroggyRun @PeterDSteinberg @brittainhard

Unless others object to this enhancement, perhaps @GoFroggyRun could prepare a webapp-public pull request that implements the new settings and changes the label on the button so that it says 5% instead of %2.

@martinholmer
Copy link
Contributor Author

Issue #574 will be resolved when PolicyBrain uses packages taxcalc>=0.12.0, which include the changes in Tax-Calculator pull request 1577.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant