Skip to content

Commit

Permalink
Update file upload hint copy writing
Browse files Browse the repository at this point in the history
  • Loading branch information
pkong-ds committed May 23, 2024
1 parent a720c9f commit 76ddce4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions public/scripts/upload.js
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ function updateFileListItem(itemNode, imageUpload) {
if (imageUpload.isErrorState) {
switch (imageUpload.readState) {
case ReadState.ErrUnsupportedFileType:
hintNode.innerText = "File extensions should be in JPG, PNG or PSD.";
hintNode.innerText = "Supported file extensions: JPG, PNG or PSD.";
break;
case ReadState.ErrExceedMaxFileSize:
hintNode.innerText = `File size should be less than ${MAX_FILE_SIZE_READABLE}.`;
Expand All @@ -334,7 +334,7 @@ function updateFileListItem(itemNode, imageUpload) {
break;
}
} else if (shouldShowAspectRatioWarning) {
hintNode.innerText = `This file has a different aspect ratio than ${recommendAspectRatio.toPrecision(
hintNode.innerText = `File aspect ratio differs from ${recommendAspectRatio.toPrecision(
3,
)} (ideally ${recommendDim.width}px * ${recommendDim.height}px).`;
}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/device/[device].astro
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ const deviceDatail: Device = DEVICE_MANAGER.getDeviceById(targetDevice);

<section class="device-info">
<div class="device-support">
<h3 class="device-support__heading">THIS DEVICE SUPPORTS</h3>
<h3 class="device-support__heading">DEVICE ORIENTATIONS</h3>
<ul class="device-support__orientation-list">
{
deviceDatail.imagePath?.map((path: string[]) => (
Expand Down
1 change: 1 addition & 0 deletions src/styles/upload.css
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ main {
width: 20px;
height: 20px;
margin: 0 8px 0 0;
flex: none;
background-size: contain;
background-repeat: no-repeat;
background-position: center;
Expand Down

0 comments on commit 76ddce4

Please sign in to comment.