`@types/bun` still conflicts with `@types/node` #8761

lgarron · 2024-02-07T19:06:39Z

What version of Bun is running?

1.0.25+a8ff7be64

What platform is your computer?

Darwin 23.2.0 arm64 arm

What steps can reproduce the bug?

mkdir /tmp/bun-node-types && cd /tmp/bun-node-types
bun init --yes
bun add @types/node @types/bun typescript
echo "{}" > tsconfig.json # Remove `skipLibCheck`
bun x tsc

What is the expected behavior?

TypeScript runs successfully.

What do you see instead?

node_modules/typescript/lib/lib.dom.d.ts:8138:11 - error TS2430: Interface 'EventSource' incorrectly extends interface 'Bun.EventSource'.
  Types of property 'onerror' are incompatible.
    Type '(this: EventSource, ev: Event) => any' is not assignable to type '(this: Bun.EventSource, ev: Event) => any'.
      The 'this' types of each signature are incompatible.
        Type 'Bun.EventSource' is not assignable to type 'EventSource'.
          Types of property 'onmessage' are incompatible.
            Type '(this: Bun.EventSource, ev: Bun.MessageEvent<any>) => any' is not assignable to type '(this: EventSource, ev: MessageEvent<any>) => any'.
              Types of parameters 'ev' and 'ev' are incompatible.
                Type 'MessageEvent<any>' is not assignable to type 'Bun.MessageEvent<any>'.
                  Types of property 'ports' are incompatible.
                    Type 'readonly MessagePort[]' is not assignable to type 'readonly import("worker_threads").MessagePort[]'.
                      Type 'MessagePort' is missing the following properties from type 'MessagePort': ref, unref, addListener, emit, and 13 more.

8138 interface EventSource extends EventTarget {
               ~~~~~~~~~~~

node_modules/typescript/lib/lib.dom.d.ts:15414:11 - error TS2430: Interface 'MessageEvent<T>' incorrectly extends interface 'Bun.MessageEvent<T>'.
  Types of property 'ports' are incompatible.
    Type 'readonly MessagePort[]' is not assignable to type 'readonly import("worker_threads").MessagePort[]'.

15414 interface MessageEvent<T = any> extends Event {
                ~~~~~~~~~~~~

node_modules/typescript/lib/lib.dom.d.ts:25362:11 - error TS2430: Interface 'WebSocket' incorrectly extends interface 'import("/private/tmp/bun-node-types/node_modules/@types/ws/index").WebSocket'.
  Types of property 'binaryType' are incompatible.
    Type 'BinaryType' is not assignable to type '"arraybuffer" | "nodebuffer" | "fragments"'.
      Type '"blob"' is not assignable to type '"arraybuffer" | "nodebuffer" | "fragments"'.

25362 interface WebSocket extends EventTarget {
                ~~~~~~~~~


Found 3 errors in the same file, starting at: node_modules/typescript/lib/lib.dom.d.ts:8138

Additional information

Also see:

This prevents me from using @types/bun in projects where @types/node is also needed. When I try to use @types/bun in cubing.js, I get additional conflicts:

node_modules/@types/node/module.d.ts:283:13 - error TS2687: All declarations of 'dirname' must have identical modifiers.

283             dirname: string;
                ~~~~~~~

node_modules/@types/node/module.d.ts:289:13 - error TS2687: All declarations of 'filename' must have identical modifiers.

289             filename: string;
                ~~~~~~~~

node_modules/bun-types/types.d.ts:601:12 - error TS2687: All declarations of 'dirname' must have identical modifiers.

601   readonly dirname: string;
               ~~~~~~~

node_modules/bun-types/types.d.ts:604:12 - error TS2687: All declarations of 'filename' must have identical modifiers.

604   readonly filename: string;
               ~~~~~~~~

node_modules/bun-types/types.d.ts:1036:20 - error TS2694: Namespace 'WebSocket' has no exported member 'WebSocket'.

1036     : import("ws").WebSocket;
                        ~~~~~~~~~

The text was updated successfully, but these errors were encountered:

mangs · 2024-02-09T04:04:22Z

Confirmed I'm seeing the same exact errors in my project too. Thank you for reporting.

charlzyx · 2024-03-01T03:52:23Z

more info , fetch work bad, no lib.dom found.

but navigator seems ok

here is my config, bun version: 1.0.29

{
  "compilerOptions": {
    "target": "ES2020",
    "moduleDetection": "force",
    "lib": ["DOM", "DOM.Iterable", "ESNext"],
    "module": "ESNext",
    "jsx": "react-jsx",
    "strict": true,
    "skipLibCheck": true,
    "isolatedModules": true,
    "resolveJsonModule": true,
    "moduleResolution": "bundler",
    "useDefineForClassFields": true,
    "allowImportingTsExtensions": true,
    "verbatimModuleSyntax": true,
    "noEmit": true,
    "noFallthroughCasesInSwitch": true,
  },
  "include": ["src", "config", "plugins"]
}

package.json

{
  "devDependencies": {
    "@types/bun": "^1.0.8",
    "typescript": "^5.3.0"
  }
}

gvelim · 2024-04-20T08:49:05Z

Experiencing same problem when running bunx tsc index.ts with or without typescript module installed.

../../../../private/tmp/bunx-501-typescript@latest/node_modules/typescript/lib/lib.dom.d.ts:8183:11 - error TS2430: Interface 'EventSource' incorrectly extends interface 'Bun.EventSource'.
  Types of property 'onerror' are incompatible.
    Type '(this: EventSource, ev: Event) => any' is not assignable to type '(this: Bun.EventSource, ev: Event) => any'.
      The 'this' types of each signature are incompatible.
        Type 'Bun.EventSource' is not assignable to type 'EventSource'.
          Types of property 'onmessage' are incompatible.
            Type '(this: Bun.EventSource, ev: Bun.MessageEvent<any>) => any' is not assignable to type '(this: EventSource, ev: MessageEvent<any>) => any'.
              Types of parameters 'ev' and 'ev' are incompatible.
                Type 'MessageEvent<any>' is not assignable to type 'Bun.MessageEvent<any>'.
                  Types of property 'ports' are incompatible.
                    Type 'readonly MessagePort[]' is not assignable to type 'readonly import("worker_threads").MessagePort[]'.
                      Type 'MessagePort' is missing the following properties from type 'MessagePort': ref, unref, addListener, emit, and 13 more.

8183 interface EventSource extends EventTarget {
               ~~~~~~~~~~~

../../../../private/tmp/bunx-501-typescript@latest/node_modules/typescript/lib/lib.dom.d.ts:15520:11 - error TS2430: Interface 'MessageEvent<T>' incorrectly extends interface 'Bun.MessageEvent<T>'.
  Types of property 'ports' are incompatible.
    Type 'readonly MessagePort[]' is not assignable to type 'readonly import("worker_threads").MessagePort[]'.

15520 interface MessageEvent<T = any> extends Event {
                ~~~~~~~~~~~~

../../../../private/tmp/bunx-501-typescript@latest/node_modules/typescript/lib/lib.dom.d.ts:25534:11 - error TS2430: Interface 'WebSocket' incorrectly extends interface 'import("/Users/milev/development/js-pe/node_modules/@types/ws/index").WebSocket'.
  Types of property 'binaryType' are incompatible.
    Type 'BinaryType' is not assignable to type '"arraybuffer" | "nodebuffer" | "fragments"'.
      Type '"blob"' is not assignable to type '"arraybuffer" | "nodebuffer" | "fragments"'.

25534 interface WebSocket extends EventTarget {
                ~~~~~~~~~

node_modules/@types/node/module.d.ts:283:13 - error TS2687: All declarations of 'dirname' must have identical modifiers.

283             dirname: string;
                ~~~~~~~

node_modules/@types/node/module.d.ts:289:13 - error TS2687: All declarations of 'filename' must have identical modifiers.

289             filename: string;
                ~~~~~~~~

node_modules/bun-types/globals.d.ts:1917:12 - error TS2687: All declarations of 'dirname' must have identical modifiers.

1917   readonly dirname: string;
                ~~~~~~~

node_modules/bun-types/globals.d.ts:1920:12 - error TS2687: All declarations of 'filename' must have identical modifiers.

1920   readonly filename: string;
                ~~~~~~~~

node_modules/bun-types/overrides.d.ts:3:20 - error TS2305: Module '"bun"' has no exported member 'PathLike'.

3 import type { Env, PathLike, BunFile } from "bun";
                     ~~~~~~~~


Found 8 errors in 4 files.

Errors  Files
     3  ../../../../private/tmp/bunx-501-typescript@latest/node_modules/typescript/lib/lib.dom.d.ts:8183
     2  node_modules/@types/node/module.d.ts:283
     2  node_modules/bun-types/globals.d.ts:1917
     1  node_modules/bun-types/overrides.d.ts:3

Modules installed

bun pm ls --all                                                                                     
node_modules
├── @types/bun@1.1.0
├── @types/node@20.11.30
├── @types/ws@8.5.10
├── bun-types@1.1.0
└── undici-types@5.26.5

yarn info -A                                                                                        
├─ @types/bun@npm:1.1.0
│  ├─ Version: 1.1.0
│  │
│  └─ Dependencies
│     └─ bun-types@npm:1.1.0 → npm:1.1.0
│
└─ js-pe@workspace:.
   ├─ Version: 0.0.0
   │
   └─ Dependencies
      └─ @types/bun@npm:^1.1.0 → npm:1.1.0

asleepace · 2024-05-07T19:38:58Z

Same issues as well

yolmcore · 2024-05-09T01:09:04Z

I got the error as well on Mac OS with @types/bun latest

KatFishSnake · 2024-05-13T18:27:47Z

Any workaround in a meantime? Would love to use bun:test 🙏

cc @Jarred-Sumner

polRk · 2024-06-02T12:44:59Z

Also different type for URL. i cant use URL with fetch...

Argument of type URL is not assignable to parameter of type string | Request | URL

This is a workaround for oven-sh/bun#8761 to allow our types to build.

piscopancer · 2024-07-14T07:55:02Z

still a bug

magick93 · 2024-08-07T02:26:55Z

I'm getting the same issues with a project that doesnt even use bun but is part of a pnpm / turborepo project, which includes a project that uses bun.

Does anyone have a solution?

michealroberts · 2024-08-20T16:49:22Z

Same issues in a very basic TypeScript project with bun ...

Joeghanoe · 2024-08-25T19:26:53Z

Same issue here, unable to use bun:test because of this... :(

cquasar · 2024-09-23T14:17:31Z

Also having trouble with it

lifenautjoe · 2024-10-03T15:09:09Z

Still happening :-(

Ollie1700 · 2024-10-14T12:12:21Z

~~We migrated to Bun on an older project that still builds with tsc -b on the build scripts. Adding tests folder to exclude in tsconfig.json worked for us:~~

Scratch that... As long as it's installed in node_modules the build fails ☹️

kravetsone · 2024-11-08T20:15:46Z

just use skipLibCheck

* feat: add elysia adapter * chore: use typings from dist and remove Promise * chore: improve package and README * chore: improve elysia example * chore: use skipLibCheck (oven-sh/bun#8761) * change: author at package * chore: bumps

* feat: add elysia adapter * chore: use typings from dist and remove Promise * chore: improve package and README * chore: improve elysia example * chore: use skipLibCheck (oven-sh/bun#8761) * change: author at package * chore: bumps * chore: support top-level await in example * chore: add docker-compose.redis for better testing * chore: a lot of fixes * chore: remove @elysiajs/static usage (switched to Bun.glob) * chore: remove `@elysiajs/static` import and switch to `elysia` at example (in user project shouldnt break types) * chore: add missing tsconfig * chore: export * chore: bumps

lgarron · 2024-11-14T23:44:55Z

This issue has gotten more severe, as it seems TypeScript now ships with @types/node built-in. So this now reproduces even if you don't explicitly include @types/node in your project:

mkdir /tmp/bun-node-types && cd /tmp/bun-node-types
bun init --yes
bun add @types/bun typescript
echo "{}" > tsconfig.json # Remove `skipLibCheck`
bun x tsc

As using tsc for type-checking can be rather important, this makes it really painful to use bun for any non-trivial project. This is the kind of thing that would be an immediate deal-breaker for me if I wasn't already a fan of bun's other benefits.

lgarron · 2024-11-14T23:55:17Z

This issue has gotten more severe, as it seems TypeScript now ships with @types/node built-in. So this now reproduces even if you don't explicitly include @types/node in your project:

Actually, it's now even worse than I thought. Even "types": ["@types/bun"] and "skipLibCheck": true fail to prevent the issue. So the repro is now just:

mkdir /tmp/bun-node-types && cd /tmp/bun-node-types
bun init --yes
bun add @types/bun typescript
bun x tsc

It is literally impossible to use the TypeScript compiler and bun in the same repo using the default configuration from bun init.

@Jarred-Sumner, @nektro: Apologies for the direct ping, but I'd really appreciate a signal about what bun plans to do about this. This is no longer possible to work around at the level of individual projects.

alii · 2024-11-22T21:03:03Z

@lgarron are you able to put together a small reproduction repo? Copying those commands exactly above but not seeing any errors from TypeScript.

lgarron · 2024-11-22T23:02:57Z

@lgarron are you able to put together a small reproduction repo? Copying those commands exactly above but not seeing any errors from TypeScript.

Woah, it looks like that one is fixed with the latest versions!

But the original repro still holds:

mkdir /tmp/bun-node-types && cd /tmp/bun-node-types
bun init --yes
bun add @types/node @types/bun typescript
echo "{}" > tsconfig.json # Remove `skipLibCheck`
bun x tsc

Here's a snapshot in a repo: https://github.com/lgarron/bun-8761-repro-snapshot

alii · 2024-11-23T01:20:43Z

@lgarron Thanks very much for that, looking into this now

lgarron added the bug Something isn't working label Feb 7, 2024

lgarron changed the title ~~@types/node still conflicts with @types/bun~~ @types/bun still conflicts with @types/node Feb 7, 2024

paperdave added the types An issue with TypeScript types label Feb 7, 2024

lgarron mentioned this issue Jun 6, 2024

Remove "skipLibCheck": true lgarron/random-uint-below.js#15

Open

lgarron added a commit to lgarron/random-uint-below.js that referenced this issue Jun 6, 2024

[tsconfig.json] Add skipLibCheck.

f1c19d6

This is a workaround for oven-sh/bun#8761 to allow our types to build.

sqikerz mentioned this issue Aug 5, 2024

[BUG]: Unable to compile with Typescript. cameronpcampbell/openblox#4

Closed

This comment has been minimized.

Sign in to view

kravetsone added a commit to kravetsone/bull-board that referenced this issue Nov 8, 2024

chore: use skipLibCheck (oven-sh/bun#8761)

280f9ad

alii self-assigned this Nov 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`@types/bun` still conflicts with `@types/node` #8761

`@types/bun` still conflicts with `@types/node` #8761

lgarron commented Feb 7, 2024 •

edited

Loading

mangs commented Feb 9, 2024

charlzyx commented Mar 1, 2024

gvelim commented Apr 20, 2024

asleepace commented May 7, 2024

yolmcore commented May 9, 2024

KatFishSnake commented May 13, 2024

polRk commented Jun 2, 2024

piscopancer commented Jul 14, 2024

magick93 commented Aug 7, 2024

michealroberts commented Aug 20, 2024

Joeghanoe commented Aug 25, 2024

cquasar commented Sep 23, 2024

lifenautjoe commented Oct 3, 2024

Ollie1700 commented Oct 14, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kravetsone commented Nov 8, 2024

lgarron commented Nov 14, 2024 •

edited

Loading

lgarron commented Nov 14, 2024

alii commented Nov 22, 2024

lgarron commented Nov 22, 2024

alii commented Nov 23, 2024

@types/bun still conflicts with @types/node #8761

@types/bun still conflicts with @types/node #8761

Comments

lgarron commented Feb 7, 2024 • edited Loading

What version of Bun is running?

What platform is your computer?

What steps can reproduce the bug?

What is the expected behavior?

What do you see instead?

Additional information

mangs commented Feb 9, 2024

charlzyx commented Mar 1, 2024

gvelim commented Apr 20, 2024

asleepace commented May 7, 2024

yolmcore commented May 9, 2024

KatFishSnake commented May 13, 2024

polRk commented Jun 2, 2024

piscopancer commented Jul 14, 2024

magick93 commented Aug 7, 2024

michealroberts commented Aug 20, 2024

Joeghanoe commented Aug 25, 2024

cquasar commented Sep 23, 2024

lifenautjoe commented Oct 3, 2024

Ollie1700 commented Oct 14, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kravetsone commented Nov 8, 2024

lgarron commented Nov 14, 2024 • edited Loading

lgarron commented Nov 14, 2024

alii commented Nov 22, 2024

lgarron commented Nov 22, 2024

alii commented Nov 23, 2024

`@types/bun` still conflicts with `@types/node` #8761

`@types/bun` still conflicts with `@types/node` #8761

lgarron commented Feb 7, 2024 •

edited

Loading

Ollie1700 commented Oct 14, 2024 •

edited

Loading

lgarron commented Nov 14, 2024 •

edited

Loading