Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building the forum image fails on arm64 #23

Closed
ghassanmas opened this issue Apr 21, 2023 · 9 comments · Fixed by openedx/cs_comments_service#411 or #27
Closed

Building the forum image fails on arm64 #23

ghassanmas opened this issue Apr 21, 2023 · 9 comments · Fixed by openedx/cs_comments_service#411 or #27
Assignees
@ghassanmas
Labels
bug Something isn't working

Comments

@ghassanmas
Copy link
Member

Building the image fails on Arm based arch/(e.g Apple silicon), due to gem lock file not supporting the platform/arch.
Docker build error:

 => ERROR [stage-0 10/12] RUN bundle install                                                                                                                                 0.3s
------                                                                                                                                                                            
 > [stage-0 10/12] RUN bundle install:                                                                                                                                            
#14 0.280 Your bundle only supports platforms ["x86_64-linux"] but your local platform is                                                                                         
#14 0.280 aarch64-linux. Add the current platform to the lockfile with `bundle lock
#14 0.280 --add-platform aarch64-linux` and try again.
------
executor failed running [/bin/sh -c bundle install]: exit code: 16

To reproduce, just build the image tutor images build forum on a device which is not Arch x86.
The suggested fix above does fix it, however it's better to resolve the issue upstream @ https://github.com/openedx/cs_comments_service.
@ghassanmas ghassanmas self-assigned this Apr 21, 2023
ghassanmas added a commit to ghassanmas/cs_comments_service that referenced this issue Apr 21, 2023
@ghassanmas
feat: allow to use two arm arch
44fe795 
 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
@ghassanmas ghassanmas mentioned this issue Apr 21, 2023
Merged
@regisb regisb added the bug Something isn't working label Apr 25, 2023
@ghassanmas ghassanmas mentioned this issue Apr 25, 2023
Merged
4 tasks
@regisb
Copy link
Contributor

regisb commented May 16, 2023

Please remember to remove the IMAGES_BUILD_PLATFORM variable from .gitlab-ci.yml when this is fixed.

regisb added a commit that referenced this issue May 16, 2023
@regisb
ci: don't build image on arm64
9e1d87a 
Build fails with:

	 => ERROR [stage-0 10/12] RUN bundle install 0.3s
	------
	 > [stage-0 10/12] RUN bundle install:
	#14 0.280 Your bundle only supports platforms ["x86_64-linux"] but your local platform is
	#14 0.280 aarch64-linux. Add the current platform to the lockfile with `bundle lock
	#14 0.280 --add-platform aarch64-linux` and try again.
	------
	executor failed running [/bin/sh -c bundle install]: exit code: 16

This issue is tracked in #23.
@regisb regisb mentioned this issue May 16, 2023
Closed
ghassanmas added a commit to ghassanmas/cs_comments_service that referenced this issue May 24, 2023
@ghassanmas
feat: allow to use two arm arch
36e9e3a 
 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
ghassanmas added a commit to ghassanmas/cs_comments_service that referenced this issue May 25, 2023
@ghassanmas
feat: allow to use two arm arch
16ae75f 
 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
ghassanmas added a commit to ghassanmas/cs_comments_service that referenced this issue Jun 6, 2023
@ghassanmas
feat: allow to use two arm arch
84b8332 
 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
ghassanmas added a commit to ghassanmas/cs_comments_service that referenced this issue Jun 6, 2023
@ghassanmas
feat: allow to use two arm arch
9d0ae4d 
 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
ghassanmas added a commit to ghassanmas/cs_comments_service that referenced this issue Jun 6, 2023
@ghassanmas
feat: allow to use two arm arch
3f41817 
 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
mtyaka pushed a commit to openedx/cs_comments_service that referenced this issue Jun 9, 2023
@ghassanmas @mtyaka
feat: allow to use two arm arch
1f0f056 
 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
@ghassanmas
Copy link
Member Author

@regisb appoligies I forgot to remove IMAGES_BUILD_PLATFORM from gitlab-ci.yml, also I found another outdate properties OPENEDX_RELEASE which still pointing lilac.

Lastly, regarding the open PR #20, which seems outdate, should I close it, and instead create new entries for v16

@regisb
Copy link
Contributor

regisb commented Jun 27, 2023

Yes, you can close #20.

@regisb
Copy link
Contributor

regisb commented Aug 9, 2023

Why close this issue? arm64 is still not supported, unless I'm mistaken.

@regisb regisb reopened this Aug 9, 2023
@regisb
Copy link
Contributor

regisb commented Aug 14, 2023

Weird... A commit in a separate repo caused this issue to be closed...

@regisb regisb reopened this Aug 14, 2023
@ghassanmas
Copy link
Member Author

ghassanmas commented Aug 15, 2023 •
edited
Loading

Aha that bceause I upgraded my fork, and in the last commit I linked it to this issue... Do we need to remove platform form the gitlab ci file in order to close this? I forgot to do it last prior to 16.x release sorry 😄

@regisb
Copy link
Contributor

regisb commented Aug 15, 2023

Can we now build the image on arm64? If yes then we should remove that line, yes.

This was referenced Sep 7, 2023
Closed
Closed
@regisb regisb changed the title Add support for Arm arch Building the forum image fails on arm64 Oct 2, 2023
@regisb
Copy link
Contributor

regisb commented Oct 2, 2023

@ghassanmas can we now build the forum image on arm64?

@regisb regisb moved this from Backlog to In Progress in Tutor project management Oct 2, 2023
ghassanmas added a commit that referenced this issue Oct 2, 2023
@ghassanmas
feat: support for ARM64 arch
7e65ad6 
 This commits closes #23
 Related upsream PR openedx/cs_comments_service/pull/411
@ghassanmas ghassanmas mentioned this issue Oct 2, 2023
Merged
@ghassanmas
Copy link
Member Author

Yes I have tested it already few times, and I just opened a PR to remove what you have suggested earlier as a next step at #27.

ghassanmas added a commit that referenced this issue Oct 17, 2023
@ghassanmas
feat: support for ARM64 arch (#27)
fee67a8 
This commits closes #23
 Related upsream PR openedx/cs_comments_service/pull/411
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tutor project management Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghassanmas ghassanmas

Labels
bug Something isn't working
Projects
Tutor project management
Status: Done
Milestone
No milestone
2 participants
@regisb @ghassanmas